[release/13.3] Make AtsJsonCodeWriter a shared internal helper#16752
Merged
joperezr merged 1 commit intorelease/13.3from May 5, 2026
Merged
[release/13.3] Make AtsJsonCodeWriter a shared internal helper#16752joperezr merged 1 commit intorelease/13.3from
joperezr merged 1 commit intorelease/13.3from
Conversation
Move the JSON code writer out of Aspire.TypeSystem so it is not exposed as public API. Link the shared internal helper into each CLI and code generation project that uses it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
aspire-repo-bot
Bot
requested review from
JamesNK,
davidfowl and
mitchdenny
as code owners
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16752Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16752" |
eerhardt
approved these changes
May 4, 2026
Contributor
|
🎬 CLI E2E Test Recordings — 68 recordings uploaded (commit View all recordings
📹 Recordings uploaded automatically from CI run #25343572370 |
joperezr
added
Servicing-approved
joperezr
approved these changes
May 5, 2026
Contributor
Author
|
No documentation PR is required for this change. Reason: This PR is an internal refactoring that makes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16677 to release/13.3
/cc @eerhardt
Customer Impact
This is unneeded public API.
Testing
Automated tests in repo.
Risk
Very low.
Regression?
No